[VAL-95] blucon.sh script assumes that it is run in validation git Created: 31/Dec/19  Updated: 22/Apr/20  Resolved: 22/Apr/20

Status: Done
Project: Validation
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Medium
Reporter: Valentin Radulescu Assignee: Alexandru Avadanii
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

image_tag=$( (git branch || echo "* local") | grep "^*" | awk '

{print $2}

')

The blucon.sh script should also be called from ci-management git in ci.
Before setting the image tag, the script should change directory to validation and after finding the image tag should go to parent folder.

 Comments   
Comment by Alexandru Avadanii [ 21/Apr/20 ]

The bug description is not very clear, hence the confusion.

The problem is not that blucon.sh runs in the context of a git repository, but that it makes 2 assumptions which are not true in the context of the CI runs:

  • the validation git repository is located in the "validation" directory (hardcoded dir name), while in CI it might be cloned in the current job workspace, called for example "bluval-daily-master";
  • the "results" dir will be created in the "validation" directory parent, while in CI we expect the "results" directory to be inside the "validation" git repository;

The pathches I proposed maintain the current behavior by default, but also allow customizing the 2 paths (for "validation" and "results" directories) via env vars that we will set for the CI runs.

Comment by Naga Sugguna [ 02/Jan/20 ]

in your case it will create a images "akraino/validation:blucon-local" and that should work without any issues.
If we do as you said that will create an image "akraino/validation:blucon-master". Expect the images tag there will not be any difference.

I can do a fix if you still need an enhancement.

Generated at Sat Feb 10 06:07:17 UTC 2024 using Jira 9.4.5#940005-sha1:e3094934eac4fd8653cf39da58f39364fb9cc7c1.